[campsite-dev] Re: [campsite-bugs] Campsite commit: r6218 - in trunk/campsite/implementation/managem - Newscoop Development Discussions on Sourcefabric Forum

Newscoop Development

[campsite-dev] Re: [campsite-bugs] Campsite commit: r6218 - in trunk/campsite/implementation/managem

Vote Up0Vote Down

import December 2006

Posts: 0Member

Hi guys -
Those checkAll()/uncheckall/setpointer/etc scripts should really be
generalized - there are like 4 copies of the same script throughout the
campsite code...
- Paul

campsite-bugs@netfinity-4.mdlf.org wrote:
> Author: mugur
> Date: 2006-12-05 18:18:03 +0100 (Tue, 05 Dec 2006)
> New Revision: 6218
>
> Added:
> trunk/campsite/implementation/management/javascript/campsite-checkbox.js
> Modified:
> trunk/campsite/implementation/management/priv/articles/audioclips/browse.php
> trunk/campsite/implementation/management/priv/articles/audioclips/cliplist.php
> trunk/campsite/implementation/management/priv/articles/audioclips/search.php
> trunk/campsite/implementation/management/priv/articles/index.php
> trunk/campsite/implementation/management/priv/templates/list_dir.php
> Log:
> updates for ticket:2326 - Attach Campcaster audio files to Campsite articles
>
> Added: trunk/campsite/implementation/management/javascript/campsite-checkbox.js
> ===================================================================
> --- trunk/campsite/implementation/management/javascript/campsite-checkbox.js (rev 0)
> +++ trunk/campsite/implementation/management/javascript/campsite-checkbox.js 2006-12-05 17:18:03 UTC (rev 6218)
> @@ -0,0 +1,93 @@
> +/**
> + * This array is used to remember mark status of rows in browse mode
> + */
> +var marked_row = new Array;
> +var default_class = new Array;
> +var defaultRowPrefix = "row_";
> +var defaultCheckboxPrefix = "checkbox_";
> +
> +function checkAll(numItems, rowPrefix, checkboxPrefix)
> +{
> + if (rowPrefix == null) {
> + rowPrefix = defaultRowPrefix;
> + }
> + if (checkboxPrefix == null) {
> + checkboxPrefix = defaultCheckboxPrefix;
> + }
> + for (i = 0; i < numItems; i++) {
> + document.getElementById(rowPrefix+i).className = 'list_row_click';
> + document.getElementById(checkboxPrefix+i).checked = true;
> + marked_row[i] = true;
> + }
> +} // fn checkAll
> +
> +
> +function uncheckAll(numItems, rowPrefix, checkboxPrefix)
> +{
> + if (rowPrefix == null) {
> + rowPrefix = defaultRowPrefix;
> + }
> + if (checkboxPrefix == null) {
> + checkboxPrefix = defaultCheckboxPrefix;
> + }
> + for (i = 0; i < numItems; i++) {
> + document.getElementById(rowPrefix+i).className = default_class[i];
> + document.getElementById(checkboxPrefix+i).checked = false;
> + marked_row[i] = false;
> + }
> +} // fn uncheckAll
> +
> +/**
> + * Sets/unsets the pointer and marker in browse mode
> + *
> + * @param object the table row
> + * @param integer the row number
> + * @param string the action calling this script (over, out or click)
> + * @param string the default class
> + *
> + * @return boolean whether pointer is set or not
> + */
> +function setPointer(theRow, theRowNum, theAction)
> +{
> + newClass = null;
> + // 4. Defines the new class
> + // 4.1 Current class is the default one
> + if (theRow.className == default_class[theRowNum]) {
> + if (theAction == 'over') {
> + newClass = 'list_row_hover';
> + }
> + }
> + // 4.1.2 Current color is the hover one
> + else if (theRow.className == 'list_row_hover'
> + && (typeof(marked_row[theRowNum]) == 'undefined' || !marked_row[theRowNum])) {
> + if (theAction == 'out') {
> + newClass = default_class[theRowNum];
> + }
> + }
> +
> + if (newClass != null) {
> + theRow.className = newClass;
> + }
> + return true;
> +} // end of the 'setPointer()' function
> +
> +/**
> + * Change the color of the row when the checkbox is selected.
> + *
> + * @param object The checkbox object.
> + * @param int The row number.
> + */
> +function checkboxClick(theCheckbox, theRowNum)
> +{
> + if (theCheckbox.checked) {
> + newClass = 'list_row_click';
> + marked_row[theRowNum] = (typeof(marked_row[theRowNum]) == 'undefined' || !marked_row[theRowNum])
> + ? true
> + : null;
> + } else {
> + newClass = 'list_row_hover';
> + marked_row[theRowNum] = false;
> + }
> + row = document.getElementById("row_"+theRowNum);
> + row.className = newClass;
> +} // fn checkboxClick
>
> Modified: trunk/campsite/implementation/management/priv/articles/audioclips/browse.php
> ===================================================================
> --- trunk/campsite/implementation/management/priv/articles/audioclips/browse.php 2006-12-05 15:54:13 UTC (rev 6217)
> +++ trunk/campsite/implementation/management/priv/articles/audioclips/browse.php 2006-12-05 17:18:03 UTC (rev 6218)
> @@ -38,87 +38,9 @@
> $pager =& new SimplePager($clipCount, $f_items_per_page, "f_audioclip_offset", $pagerUrl);
> ?>
>
> -
>
> -function checkAll()
> -{
> - for (i = 0; i < ; i++) {
> - document.getElementById("rw_"+i).className = 'list_row_click';
> - document.getElementById("checkbox_"+i).checked = true;
> - marked_row[i] = true;
> - }
> -} // fn checkAll
> -
> -
> -function uncheckAll()
> -{
> - for (i = 0; i < ; i++) {
> - document.getElementById("rw_"+i).className = default_class[i];
> - document.getElementById("checkbox_"+i).checked = false;
> - marked_row[i] = false;
> - }
> -} // fn uncheckAll
> -
> -/**
> - * Sets/unsets the pointer and marker in browse mode
> - *
> - * @param object the table row
> - * @param integer the row number
> - * @param string the action calling this script (over, out or click)
> - * @param string the default class
> - *
> - * @return boolean whether pointer is set or not
> - */
> -function setPointer(theRow, theRowNum, theAction)
> -{
> - newClass = null;
> - // 4. Defines the new class
> - // 4.1 Current class is the default one
> - if (theRow.className == default_class[theRowNum]) {
> - if (theAction == 'over') {
> - newClass = 'list_row_hover';
> - }
> - }
> - // 4.1.2 Current color is the hover one
> - else if (theRow.className == 'list_row_hover'
> - && (typeof(marked_row[theRowNum]) == 'undefined' || !marked_row[theRowNum])) {
> - if (theAction == 'out') {
> - newClass = default_class[theRowNum];
> - }
> - }
> -
> - if (newClass != null) {
> - theRow.className = newClass;
> - }
> - return true;
> -} // end of the 'setPointer()' function
> -
> -/**
> - * Change the color of the row when the checkbox is selected.
> - *
> - * @param object The checkbox object.
> - * @param int The row number.
> - */
> -function checkboxClick(theCheckbox, theRowNum)
> -{
> - if (theCheckbox.checked) {
> - newClass = 'list_row_click';
> - marked_row[theRowNum] = (typeof(marked_row[theRowNum]) == 'undefined' || !marked_row[theRowNum])
> - ? true
> - : null;
> - } else {
> - newClass = 'list_row_hover';
> - marked_row[theRowNum] = false;
> - }
> - row = document.getElementById("rw_"+theRowNum);
> - row.className = newClass;
> -} // fn checkboxClick
> -
> +
>
> -
> -
> -
> -
> -

> - " onclick="checkAll();">
> - " onclick="uncheckAll();">
> -

> -
> -
> -
> -
> -
> -
> - userCanModify($g_user)) { ?>
> -
> -
> -
> -
> -
> -
> > require('cliplist.php');
> ?>
> -
> -
> -
> -
> -
> -

	> - > -	> - > -	> - > -
> - > -		> - > -

>
>
>
>
>
>
>

>
> Modified: trunk/campsite/implementation/management/priv/articles/audioclips/cliplist.php
> ===================================================================
> --- trunk/campsite/implementation/management/priv/articles/audioclips/cliplist.php 2006-12-05 15:54:13 UTC (rev 6217)
> +++ trunk/campsite/implementation/management/priv/articles/audioclips/cliplist.php 2006-12-05 17:18:03 UTC (rev 6218)
> @@ -1,3 +1,31 @@
> +
> +
> +
> +
> +

> + " onclick="checkAll(, 'rw_');">
> + " onclick="uncheckAll(, 'rw_');">
> +

> +
> +
> +
> +
> +
> +
> + userCanModify($g_user)) { ?>
> +
> +
> +
> +
> +
> +
> +
> > $color = 0;
> $counter = 0;
> @@ -45,3 +73,21 @@
> $counter++;
> } // foreach
> ?>
> +
> +
> +
> +
> +
> +
> +

	> + > +	> + > +	> + > +
> + > +		> + > +

> +
> +
> +
> +
> +

> + render(); ?>
> +

>
> Modified: trunk/campsite/implementation/management/priv/articles/audioclips/search.php
> ===================================================================
> --- trunk/campsite/implementation/management/priv/articles/audioclips/search.php 2006-12-05 15:54:13 UTC (rev 6217)
> +++ trunk/campsite/implementation/management/priv/articles/audioclips/search.php 2006-12-05 17:18:03 UTC (rev 6218)
> @@ -117,87 +117,9 @@
>
> ?>
>
> -
>
> -function checkAll()
> -{
> - for (i = 0; i < ; i++) {
> - document.getElementById("rw_"+i).className = 'list_row_click';
> - document.getElementById("checkbox_"+i).checked = true;
> - marked_row[i] = true;
> - }
> -} // fn checkAll
> -
> -
> -function uncheckAll()
> -{
> - for (i = 0; i < ; i++) {
> - document.getElementById("rw_"+i).className = default_class[i];
> - document.getElementById("checkbox_"+i).checked = false;
> - marked_row[i] = false;
> - }
> -} // fn uncheckAll
> -
> -/**
> - * Sets/unsets the pointer and marker in browse mode
> - *
> - * @param object the table row
> - * @param integer the row number
> - * @param string the action calling this script (over, out or click)
> - * @param string the default class
> - *
> - * @return boolean whether pointer is set or not
> - */
> -function setPointer(theRow, theRowNum, theAction)
> -{
> - newClass = null;
> - // 4. Defines the new class
> - // 4.1 Current class is the default one
> - if (theRow.className == default_class[theRowNum]) {
> - if (theAction == 'over') {
> - newClass = 'list_row_hover';
> - }
> - }
> - // 4.1.2 Current color is the hover one
> - else if (theRow.className == 'list_row_hover'
> - && (typeof(marked_row[theRowNum]) == 'undefined' || !marked_row[theRowNum])) {
> - if (theAction == 'out') {
> - newClass = default_class[theRowNum];
> - }
> - }
> -
> - if (newClass != null) {
> - theRow.className = newClass;
> - }
> - return true;
> -} // end of the 'setPointer()' function
> -
> -/**
> - * Change the color of the row when the checkbox is selected.
> - *
> - * @param object The checkbox object.
> - * @param int The row number.
> - */
> -function checkboxClick(theCheckbox, theRowNum)
> -{
> - if (theCheckbox.checked) {
> - newClass = 'list_row_click';
> - marked_row[theRowNum] = (typeof(marked_row[theRowNum]) == 'undefined' || !marked_row[theRowNum])
> - ? true
> - : null;
> - } else {
> - newClass = 'list_row_hover';
> - marked_row[theRowNum] = false;
> - }
> - row = document.getElementById("rw_"+theRowNum);
> - row.className = newClass;
> -} // fn checkboxClick
> -
> +
>
> -
> -
> -
> -
> -

> - " onclick="checkAll();">
> - " onclick="uncheckAll();">
> -

> -
> -
> -
> -
> -
> -
> - userCanModify($g_user)) { ?>
> -
> -
> -
> -
> -
> -
> > require('cliplist.php');
> -?>
> -
> -
> -
> -
> -
> -

	> - > -	> - > -	> - > -
> - > -		> - > -

> -
> -
> -
> -
> -

> - render(); ?>
> -

> - > } else {
> ?>
>
>
> Modified: trunk/campsite/implementation/management/priv/articles/index.php
> ===================================================================
> --- trunk/campsite/implementation/management/priv/articles/index.php 2006-12-05 15:54:13 UTC (rev 6217)
> +++ trunk/campsite/implementation/management/priv/articles/index.php 2006-12-05 17:18:03 UTC (rev 6218)
> @@ -101,6 +101,8 @@
> include_once($_SERVER['DOCUMENT_ROOT']."/$ADMIN_DIR/javascript_common.php");
>
> ?>
> +
> +
>

>
>
> @@ -113,87 +115,6 @@
>

/left_arrow.png" BORDER="0">

>
> -
>

> - " onclick="checkAll();">
> - " onclick="uncheckAll();">
> + " onclick="checkAll();">
> + " onclick="uncheckAll();">
>

>
> Modified: trunk/campsite/implementation/management/priv/templates/list_dir.php
> ===================================================================
> --- trunk/campsite/implementation/management/priv/templates/list_dir.php 2006-12-05 15:54:13 UTC (rev 6217)
> +++ trunk/campsite/implementation/management/priv/templates/list_dir.php 2006-12-05 17:18:03 UTC (rev 6218)
> @@ -37,87 +37,8 @@
>
> ?>
>
> -
>
> -function checkAll()
> -{
> - for (i = 0; i < ; i++) {
> - document.getElementById("row_"+i).className = 'list_row_click';
> - document.getElementById("checkbox_"+i).checked = true;
> - marked_row[i] = true;
> - }
> -} // fn checkAll
> -
> -
> -function uncheckAll()
> -{
> - for (i = 0; i < ; i++) {
> - document.getElementById("row_"+i).className = default_class[i];
> - document.getElementById("checkbox_"+i).checked = false;
> - marked_row[i] = false;
> - }
> -} // fn uncheckAll
> -
> -/**
> - * Sets/unsets the pointer and marker in browse mode
> - *
> - * @param object the table row
> - * @param integer the row number
> - * @param string the action calling this script (over, out or click)
> - * @param string the default class
> - *
> - * @return boolean whether pointer is set or not
> - */
> -function setPointer(theRow, theRowNum, theAction)
> -{
> - newClass = null;
> - // 4. Defines the new class
> - // 4.1 Current class is the default one
> - if (theRow.className == default_class[theRowNum]) {
> - if (theAction == 'over') {
> - newClass = 'list_row_hover';
> - }
> - }
> - // 4.1.2 Current color is the hover one
> - else if (theRow.className == 'list_row_hover'
> - && (typeof(marked_row[theRowNum]) == 'undefined' || !marked_row[theRowNum])) {
> - if (theAction == 'out') {
> - newClass = default_class[theRowNum];
> - }
> - }
> -
> - if (newClass != null) {
> - theRow.className = newClass;
> - }
> - return true;
> -} // end of the 'setPointer()' function
> -
> -/**
> - * Change the color of the row when the checkbox is selected.
> - *
> - * @param object The checkbox object.
> - * @param int The row number.
> - */
> -function checkboxClick(theCheckbox, theRowNum)
> -{
> - if (theCheckbox.checked) {
> - newClass = 'list_row_click';
> - marked_row[theRowNum] = (typeof(marked_row[theRowNum]) == 'undefined' || !marked_row[theRowNum])
> - ? true
> - : null;
> - } else {
> - newClass = 'list_row_hover';
> - marked_row[theRowNum] = false;
> - }
> - row = document.getElementById("row_"+theRowNum);
> - row.className = newClass;
> -} // fn checkboxClick
> -
>
>
>
> @@ -207,8 +128,8 @@
>
>
>
>
>

> - " onclick="checkAll();">
> - " onclick="uncheckAll();">
> + " onclick="checkAll();">
> + " onclick="uncheckAll();">
>

>
> _______________________________________________
> campsite-bugs mailing list
> campsite-bugs@lists.campware.org
> http://lists.campware.org/mailman/listinfo/campsite-bugs
>

1 Comment sorted by
- Votes
- Date Added
Vote Up0Vote Down import April 2010
Posts: 0Member

That's what I did, I put the javascript code in campsite-checkbox.js and included this file
wherever it's needed. I also modified checkAll() and uncheckAll() functions to be more generic.

Mugur

--- Paul Baranowski wrote:
> Hi guys -
> Those checkAll()/uncheckall/setpointer/etc scripts should really be
> generalized - there are like 4 copies of the same script throughout the
> campsite code...
> - Paul
>
>
> campsite-bugs@netfinity-4.mdlf.org wrote:
> > Author: mugur
> > Date: 2006-12-05 18:18:03 +0100 (Tue, 05 Dec 2006)
> > New Revision: 6218
> >
> > Added:
> > trunk/campsite/implementation/management/javascript/campsite-checkbox.js
> > Modified:
> > trunk/campsite/implementation/management/priv/articles/audioclips/browse.php
> > trunk/campsite/implementation/management/priv/articles/audioclips/cliplist.php
> > trunk/campsite/implementation/management/priv/articles/audioclips/search.php
> > trunk/campsite/implementation/management/priv/articles/index.php
> > trunk/campsite/implementation/management/priv/templates/list_dir.php
> > Log:
> > updates for ticket:2326 - Attach Campcaster audio files to Campsite articles
> >
> > Added: trunk/campsite/implementation/management/javascript/campsite-checkbox.js
> > ===================================================================
> > --- trunk/campsite/implementation/management/javascript/campsite-checkbox.js
> (rev 0)
> > +++ trunk/campsite/implementation/management/javascript/campsite-checkbox.js 2006-12-05
> 17:18:03 UTC (rev 6218)
> > @@ -0,0 +1,93 @@
> > +/**
> > + * This array is used to remember mark status of rows in browse mode
> > + */
> > +var marked_row = new Array;
> > +var default_class = new Array;
> > +var defaultRowPrefix = "row_";
> > +var defaultCheckboxPrefix = "checkbox_";
> > +
> > +function checkAll(numItems, rowPrefix, checkboxPrefix)
> > +{
> > + if (rowPrefix == null) {
> > + rowPrefix = defaultRowPrefix;
> > + }
> > + if (checkboxPrefix == null) {
> > + checkboxPrefix = defaultCheckboxPrefix;
> > + }
> > + for (i = 0; i < numItems; i++) {
> > + document.getElementById(rowPrefix+i).className = 'list_row_click';
> > + document.getElementById(checkboxPrefix+i).checked = true;
> > + marked_row[i] = true;
> > + }
> > +} // fn checkAll
> > +
> > +
> > +function uncheckAll(numItems, rowPrefix, checkboxPrefix)
> > +{
> > + if (rowPrefix == null) {
> > + rowPrefix = defaultRowPrefix;
> > + }
> > + if (checkboxPrefix == null) {
> > + checkboxPrefix = defaultCheckboxPrefix;
> > + }
> > + for (i = 0; i < numItems; i++) {
> > + document.getElementById(rowPrefix+i).className = default_class[i];
> > + document.getElementById(checkboxPrefix+i).checked = false;
> > + marked_row[i] = false;
> > + }
> > +} // fn uncheckAll
> > +
> > +/**
> > + * Sets/unsets the pointer and marker in browse mode
> > + *
> > + * @param object the table row
> > + * @param integer the row number
> > + * @param string the action calling this script (over, out or click)
> > + * @param string the default class
> > + *
> > + * @return boolean whether pointer is set or not
> > + */
> > +function setPointer(theRow, theRowNum, theAction)
> > +{
> > + newClass = null;
> > + // 4. Defines the new class
> > + // 4.1 Current class is the default one
> > + if (theRow.className == default_class[theRowNum]) {
> > + if (theAction == 'over') {
> > + newClass = 'list_row_hover';
> > + }
> > + }
> > + // 4.1.2 Current color is the hover one
> > + else if (theRow.className == 'list_row_hover'
> > + && (typeof(marked_row[theRowNum]) == 'undefined' || !marked_row[theRowNum])) {
> > + if (theAction == 'out') {
> > + newClass = default_class[theRowNum];
> > + }
> > + }
> > +
> > + if (newClass != null) {
> > + theRow.className = newClass;
> > + }
> > + return true;
> > +} // end of the 'setPointer()' function
> > +
> > +/**
> > + * Change the color of the row when the checkbox is selected.
> > + *
> > + * @param object The checkbox object.
> > + * @param int The row number.
> > + */
> > +function checkboxClick(theCheckbox, theRowNum)
> > +{
> > + if (theCheckbox.checked) {
> > + newClass = 'list_row_click';
> > + marked_row[theRowNum] = (typeof(marked_row[theRowNum]) == 'undefined' ||
> !marked_row[theRowNum])
> > + ? true
> > + : null;
> > + } else {
> > + newClass = 'list_row_hover';
> > + marked_row[theRowNum] = false;
> > + }
> > + row = document.getElementById("row_"+theRowNum);
> > + row.className = newClass;
> > +} // fn checkboxClick
> >
> > Modified: trunk/campsite/implementation/management/priv/articles/audioclips/browse.php
> > ===================================================================
> > --- trunk/campsite/implementation/management/priv/articles/audioclips/browse.php 2006-12-05
> 15:54:13 UTC (rev 6217)
> > +++ trunk/campsite/implementation/management/priv/articles/audioclips/browse.php 2006-12-05
> 17:18:03 UTC (rev 6218)
> > @@ -38,87 +38,9 @@
> > $pager =& new SimplePager($clipCount, $f_items_per_page, "f_audioclip_offset",
> $pagerUrl);
> > ?>
> >
> > -
> >
> > -function checkAll()
> > -{
> > - for (i = 0; i < ; i++) {
> > - document.getElementById("rw_"+i).className = 'list_row_click';
> > - document.getElementById("checkbox_"+i).checked = true;
> > - marked_row[i] = true;
> > - }
> > -} // fn checkAll
> > -
> > -
> > -function uncheckAll()
> > -{
> > - for (i = 0; i < ; i++) {
> > - document.getElementById("rw_"+i).className = default_class[i];
> > - document.getElementById("checkbox_"+i).checked = false;
> > - marked_row[i] = false;
> > - }
> > -} // fn uncheckAll
> > -
> > -/**
> > - * Sets/unsets the pointer and marker in browse mode
> > - *
> > - * @param object the table row
> > - * @param integer the row number
> > - * @param string the action calling this script (over, out or click)
> > - * @param string the default class
> > - *
> > - * @return boolean whether pointer is set or not
> > - */
> > -function setPointer(theRow, theRowNum, theAction)
> > -{
> > - newClass = null;
> > - // 4. Defines the new class
> > - // 4.1 Current class is the default one
> > - if (theRow.className == default_class[theRowNum]) {
> > - if (theAction == 'over') {
> > - newClass = 'list_row_hover';
> > - }
> > - }
> > - // 4.1.2 Current color is the hover one
> > - else if (theRow.className == 'list_row_hover'
> > - && (typeof(marked_row[theRowNum]) == 'undefined' || !marked_row[theRowNum])) {
> > - if (theAction == 'out') {
> > - newClass = default_class[theRowNum];
> > - }
> > - }
> > -
> > - if (newClass != null) {
> > - theRow.className = newClass;
> > - }
> > - return true;
> > -} // end of the 'setPointer()' function
> > -
> > -/**
> > - * Change the color of the row when the checkbox is selected.
> > - *
>
=== message truncated ===

____________________________________________________________________________________
Do you Yahoo!?
Everyone is raving about the all-new Yahoo! Mail beta.
http://new.mail.yahoo.com

Add a Comment

Start a New Discussion

Howdy, Stranger!

It looks like you're new here. If you want to get involved, click one of these buttons!

Poll

No poll attached to this discussion.

Howdy, Stranger!

Categories

Poll

Top Posters